he obvious insinuation contained in the above question is that "since it takes on average one million years for photons created in the sun's core to escape from the sun's surface," the age of the Earth can't possibly be the less-than-10,000 years that biblical Creationists claim.
In response to the question, let's establish the facts and dismiss erroneous claims.
First, those "million-year" time frames would be valid only if the present knowledge and models are correct. If what people today think they know is wrong, then what they derive from this is going to be just as wrong. Specifically, the figure of "one million years" is not a direct measurement but rather a computed result based on present models and understandings. It is far from being an established fact that those models and understandings are correct in every detail.
Second, even if we accept present models we find that the actual values that these models yield are nowhere near "one million years". It is common to hear such values - some even as high as ten million years - being tossed out. These models compute the transit time of photons from the sun's core based on a random walk process. Here's what NASA says are the actual results:
"When this random walk process is applied to the interior of the sun, and an accurate model of the solar interior is used, most answers for the age of sunlight come out to be between 10,000 and 170,000 years. Rarely do you get answers greater than a million years unless you have made a serious error! Why do you still see these erroneous estimates of '10 million years' still being used? Because textbook authors and editors do not bother to actually make the correct calculation themselves, and rely on older published answers from similar textbooks."
Reference: Mitalas, R. and Sills, K. 1992, "On the photon diffusion time scale for the sun", The Astrophysical Journal, Vol. 401, p. 759-760. Source: http://sunearthday.nasa.gov/2007/locations/ttt_sunlight.php
Light-transit models typically include that light escapes the sun's core through a series of random steps as it is absorbed and emitted by atoms along the way (Courtesy - Richard Pogge, Ohio State University).
Therefore, even as per mainstream estimates there are no "millions" of years in the transit time of solar photons. Furthermore, those computed values of 10,000 - 170,000 years are valid if and only if the multiple models (e.g., random walk, solar interior, etc.) that are used are correct in every detail. It is unwise and unjustifiable to assume that such infallibility is the case here.
Third, let's analyze the situation a little closer. When God created the sun, it was a mature star from the start. In other words, God created the sun to be functional from the very first moment, not thousands or millions of years later. Adam was created as a mature person, not as an embryo; trees were created fully grown, not as seedlings. In like fashion, God created the sun as a fully mature, extremely hot body of gas emitting photons not just from its core but from every layer of its structure, including the surface. Recall that the sun's surface temperature is approximately 5,500 °C and, thus, matter there exists in the plasma state emitting photons.
In summary, these simple points demonstrate that solar photons could certainly have been arriving on Earth moments after God created the sun, not millions of years later as certain people claim. At the very least, it has been demonstrated here that this objection to biblical Creation is extremely weak and flawed.